Skip to content

Hide std::unreachable_sentinel_t's friends harder#352

Merged
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
CaseyCarter:replay2
Dec 5, 2019
Merged

Hide std::unreachable_sentinel_t's friends harder#352
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
CaseyCarter:replay2

Conversation

@CaseyCarter
Copy link
Copy Markdown
Contributor

Description

Hidden friends aren't hidden in C1XX's permissive mode, so let's use an alternate mechanism to make these operators truly ADL-only. (We want to avoid checking weakly_incrementable for every type that is compared via == or != with a type associated with namespace std.)

[This is a replay of Microsoft-internal MSVC-PR-216763.]

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

Hidden friends aren't hidden in C1XX's permissive mode, so let's use an alternate mechanism to make these operators truly ADL-only. (We want to avoid checking `weakly_incrementable` for every type that is compared via `==` or `!=` with a type associated with namespace `std`.)
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 4, 2019 22:53
@StephanTLavavej StephanTLavavej merged commit d42d1cd into microsoft:master Dec 5, 2019
@CaseyCarter CaseyCarter deleted the replay2 branch December 5, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants