Skip to content

Reorganize libc++ skips#3464

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
CaseyCarter:skips
Feb 14, 2023
Merged

Reorganize libc++ skips#3464
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
CaseyCarter:skips

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Feb 13, 2023

  • All "libc++ doesn't implement (some proposal or LWG issue)" comments should be in the "ISSUES REPORTED/KNOWN UPSTREAM" section: libc++ knows what work WG21 has approved as well as we do.
  • Strike noise word "yet" from all comments (e.g., "not yet implemented", "not yet analyzed")
  • order "MISSING STL FEATURES" by proposal number

@CaseyCarter
Reorganize libc++ skips
3ad9360 
* All "libc++ doesn't implement (some proposal or LWG issue)" comments should be in the "ISSUES REPORTED/KNOWN UPSTREAM" section: libc++ knows what work WG21 has approved as well as we do.
* Strike noise word "yet" from all comments (e.g., "not yet implemented", "not yet analyzed")
* order "MISSING STL FEATURES" by proposal number
@CaseyCarter CaseyCarter added the test Related to test code label Feb 13, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 13, 2023 16:57
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 13, 2023

Verified no divergence between the files. I couldn't resist resetting testing when I saw a pre-existing typo 😸

I will note that I can't think of a more conflict-prone time to perform such a cleanup than right after a batch of C++23 features and LWG issues appeared, but it's not actually that annoying to resolve such conflicts. 😹

@CaseyCarter CaseyCarter mentioned this pull request Feb 13, 2023
Merged
@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Feb 13, 2023

I will note that I can't think of a more conflict-prone time to perform such a cleanup than right after a batch of C++23 features and LWG issues appeared, but it's not actually that annoying to resolve such conflicts. 😹

LMK if you do think of a more conflict-prone time so I can close this and resubmit.

@StephanTLavavej StephanTLavavej self-assigned this Feb 13, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 13, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 14, 2023

I've pushed a merge with main to resolve simple adjacent-add/move conflicts. I understand that you have to periodically renew your nickname, Casey "Conflict" Carter 😹

@StephanTLavavej StephanTLavavej merged commit d4f1e09 into microsoft:main Feb 14, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 14, 2023

Thanks for the cleanup! 🧹 ✨ 🪄

@CaseyCarter CaseyCarter deleted the skips branch February 14, 2023 04:53
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaseyCarter @StephanTLavavej