P2165R4: Compatibility Between tuple, pair, And tuple-like Objects#3372
Merged
StephanTLavavej merged 45 commits intomicrosoft:mainfrom Feb 26, 2023
Merged
P2165R4: Compatibility Between tuple, pair, And tuple-like Objects#3372StephanTLavavej merged 45 commits intomicrosoft:mainfrom
tuple, pair, And tuple-like Objects#3372StephanTLavavej merged 45 commits intomicrosoft:mainfrom
Conversation
Also fix `_Guide_key_t`
tuple, pair, And *tuple-like* Objectstuple, pair, And tuple-like Objects
frederick-vs-ja
suggested changes
Jan 30, 2023
Maybe, I am not sure :( Also, skip some LLVM tests due to failing static assertions in new hidden friends
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
JMazurkiewicz
commented
Jan 31, 2023
strega-nil-ms
approved these changes
Feb 7, 2023
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Feb 14, 2023
|
LWG issue for the friendship bug with proposed resolution (matching this implementation) https://cplusplus.github.io/LWG/issue3882 (Thanks for pinging me about that!) |
StephanTLavavej
approved these changes
Feb 22, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Pushing a partial review; should finish tmrw
strega-nil-ms
approved these changes
Feb 23, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks great; thanks @JMazurkiewicz!
StephanTLavavej
approved these changes
Feb 23, 2023
Member
|
Looks good to me too. I've pushed one last commit to improve the merge with #3483's reformatting, FYI @strega-nil-ms. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Feb 25, 2023
Member
|
I've pushed a commit to address several issues that I found while mirroring:
|
Member
|
Thanks again, one more step closer to C++23! 😻 🎉 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2917.