Implement LWG-3798 Rvalue reference and iterator_category#3359
Merged
StephanTLavavej merged 6 commits intomicrosoft:mainfrom Jan 28, 2023
Merged
Implement LWG-3798 Rvalue reference and iterator_category#3359StephanTLavavej merged 6 commits intomicrosoft:mainfrom
iterator_category#3359StephanTLavavej merged 6 commits intomicrosoft:mainfrom
Conversation
For: - `cpp17-forward-iterator` - `transform_view` - `join_with_view`
For `cpp17-forward-iterator`, `transform_view`, and `join_with_view`.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I analyzed the buggy cases for Clang and reported LLVM-60293. There are a large number of default constructors that are defaulted and constrained by |
StephanTLavavej
approved these changes
Jan 26, 2023
Member
|
Thanks for implementing this, adding significant test coverage, and investigating/reporting the Clang bug! Looks good to me too, after pushing minor changes to fix WP citations, a pre-existing typo, |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing and extensively testing this LWG issue resolution! 📉 😻 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3228.
Also updates references to working draft in
<ranges>andP0896R4_ranges_iterator_machinery/test.cppto WG21-N4928.Not all changes in LWG-3798 are implemented in this PR.
std::views::zip_transform. #3322zip#2252, asviews::adjacent_transformhasn't been implemented yet.