P2404R3: Move-Only Types For Comparison Concepts#3345
Merged
StephanTLavavej merged 7 commits intomicrosoft:mainfrom Jan 28, 2023
Merged
P2404R3: Move-Only Types For Comparison Concepts#3345StephanTLavavej merged 7 commits intomicrosoft:mainfrom
StephanTLavavej merged 7 commits intomicrosoft:mainfrom
Conversation
d7a4ab0 to
a62e88c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
strega-nil-ms
suggested changes
Jan 24, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Mostly looks good! Just that minor change in yvals_core.h requested :)
strega-nil-ms
approved these changes
Jan 24, 2023
tests/std/tests/P2404R3_move_only_types_for_comparison_concepts/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2404R3_move_only_types_for_comparison_concepts/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2404R3_move_only_types_for_comparison_concepts/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jan 25, 2023
Member
|
Thanks, looks great! I pushed changes to fix the paper citation for C++20 concepts, and ultra-minor test nitpicks. FYI @strega-nil-ms. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this C++23 feature and improving these concepts! 🚀 😻 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2924.
This PR adds support for move-only types to C++20 concepts:
three_way_comparable_with,equality_comparable_withandtotally_ordered_with.