Update LLVM submodule#3344
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Jan 22, 2023
Merged
Conversation
Update SHA and skip list(s), and some other changes: * Tell `features.py` that we support `ja_JP.UTF-8`. Some of the libcxx `<format>`/`chronat` tests use that locale. * Build libcxx tests with `/utf-8`. They write tests with the expectation that the source and execution character sets are both UTF-8, we should make it so to avoid failures. * Build libcxx tests with [C6262 "Excessive stack size"](https://learn.microsoft.com/en-us/cpp/code-quality/c6262?view=msvc-170) disabled. A few tests use a ton of stack, and run just fine. It's not product code, and IMO not worth our time or theirs to rewrite such tests.
StephanTLavavej
approved these changes
Jan 12, 2023
Member
|
Looks good - verified zero divergence between Thanks for this big update, I know how much work it is! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for this major 😻 🐈⬛ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SHA and skip list(s), and some other changes:
features.pythat we supportja_JP.UTF-8. Some of the libcxx<format>/chronattests use that locale./utf-8. They write tests with the expectation that the source and execution character sets are both UTF-8, we should make it so to avoid failures.