P2165R4: Compatibility Between tuple, pair, And tuple-like Objects (changes to pair only)#3323
Merged
StephanTLavavej merged 16 commits intomicrosoft:mainfrom Jan 22, 2023
Merged
Conversation
* Implement pair-like concept * Change header dependency -> now `<utility>` includes `<__msvc_iter_core.hpp>`, not the other way around * Move `tuple_size`, `tuple_element` and some internal machinery to `<__msvc_iter_core.hpp>` * `<tuple>` and `<xutility>` headers include `<utility>` now (not `<__msvc_iter_core.hpp>`) * Relocate some more stuff inside of `<utility>` header and add `pair` forward declaration * Move `_Different_from` concept from `<xutility>` to `<utility> * Move `_Is_subrange` variable from `<ranges>` to `<utility>` and rename it to `_Is_subrange_v` * Move `_Is_std_array_v` variable from `<span>` to `<utility>`
… from new forward declarations
Contributor
frederick-vs-ja
left a comment
There was a problem hiding this comment.
I'm afraid that changing header depencendy might damage throughput (although perhaps slightly).
strega-nil-ms
suggested changes
Jan 5, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks great! One minor change requested - can you drop the strict requirement on the test?
StephanTLavavej
approved these changes
Jan 20, 2023
Member
|
Thanks - flawless product code as far as I can tell! 😻 I pushed a commit to drop |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for implementing more of this C++23 feature! 😻 📉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2917. Implements changes to [pairs] section.
The other goal of this PR is to move around some stuff, so that implementation of
tuple-likeconcept is possible:_Different_fromconcept from<xutility>to<utility>,_Is_subrangevariable template from<ranges>to<utility>and rename it to_Is_subrange_v,_Is_std_array_vvariable from<span>to<utility>,