Implement LWG-3737 take_view::sentinel should provide operator-#3320
Implement LWG-3737 take_view::sentinel should provide operator-#3320StephanTLavavej merged 5 commits intomicrosoft:mainfrom
take_view::sentinel should provide operator-#3320Conversation
CaseyCarter
left a comment
There was a problem hiding this comment.
LGTM, just some style nits.
strega-nil-ms
left a comment
There was a problem hiding this comment.
LGTM, although the utility of this LWG issue seems suspect to me lol (given that it only triggers when disable_sized_range<R> && sized_sentinel_for<S, I>)
More precisely, it's |
|
Thanks! Really appreciate the test case, especially when it's non-trivial to set up like this one. @CaseyCarter @strega-nil-ms I pushed changes after you approved, to defend against |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for taking the STL to the next level of conformance! 📊 🎉 😹 |
Fixes #3223.
(
counted_iterator<counted_iterator<T>>seems a bit messy. Should I add a prettier test case?)