Use emplace_front in filesystem#3279
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Dec 15, 2022
Merged
Conversation
strega-nil-ms
approved these changes
Dec 12, 2022
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This seems reasonable to me. Thanks!
CaseyCarter
approved these changes
Dec 12, 2022
StephanTLavavej
approved these changes
Dec 12, 2022
Member
|
Looks good to me. This is strictly simpler, and the scenario where replacing |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for finding and simplifying this code! ✨ 🎉 🐈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emplace_front would work better here than push_front, especially when we don't have to copy the object then