Implement LWG-3629 make_error_code and make_error_condition are customization points#3272
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Dec 15, 2022
Merged
Conversation
- make sure invocations for `std::` overloads - drop `std::` for types
StephanTLavavej
approved these changes
Dec 7, 2022
Member
|
Looks great! I pushed a couple of trivial changes. Thanks for adding the |
CaseyCarter
approved these changes
Dec 7, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Nitpicky, non-functional changes. I'll push a change to address my comments.
|
|
||
| namespace _Ensure_adl { | ||
| void make_error_code() = delete; | ||
| void make_error_condition() = delete; |
Contributor
There was a problem hiding this comment.
For other reviewers: this change doesn't need to workaround the MSVC bug that was an issue for the CPOs (#3215 (comment)), that bug only affects names in requires-expressions. (No change requested.)
StephanTLavavej
approved these changes
Dec 7, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for implementing this LWG issue resolution! 🎉 📈 🐱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3216.
Also adding
_STD-qualifications to calls in<future>and<xiosbase>, because these calls always find overloads declared instd::and it is unnecessary to enable ADL for them.Some previously accepted codes will be rejected after these changes. Unfortunately, I don't know how to examine such cases in tests, because only hard errors would occur.