Qualify calls to helpers that are in both _STD and _RANGES#3270
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Dec 15, 2022
Merged
Qualify calls to helpers that are in both _STD and _RANGES#3270StephanTLavavej merged 1 commit intomicrosoft:mainfrom
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
I've also consistently qualified calls to namespace-scope function templates ("things") defined in `_RANGES` that have both qualified and unqualified calls. I have _not_ qualified calls to things defined only in either `_STD` or `_RANGES` for which all existing calls are unqualified. (This isn't trying to be a "let's qualify all ugly calls" change, but only "let's make it clear that we're fixing microsoft#3203".)
Fixes microsoft#3203
StephanTLavavej
approved these changes
Dec 7, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Ha, just noticed your branch name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also consistently qualified calls to namespace-scope function templates ("things") defined in
_RANGESthat have both qualified and unqualified calls. I have not qualified calls to things defined only in either_STDor_RANGESfor which all existing calls are unqualified. (This isn't trying to be a "let's qualify all ugly calls" change, but only "let's make it clear that we're fixing #3203".)Fixes #3203