Convert arguments to double in _GENERIC_MATH2_BASE#3253
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom Dec 6, 2022
Merged
Convert arguments to double in _GENERIC_MATH2_BASE#3253StephanTLavavej merged 4 commits intomicrosoft:mainfrom
_GENERIC_MATH2_BASE#3253StephanTLavavej merged 4 commits intomicrosoft:mainfrom
Conversation
This template implements the "sufficient additional overloads" for two-argument `<cmath>` functions (`atan2`, `hypot`, `pow`, `fmod`, `remainder`, `copysign`, `nextafter`, `fdim`, `fmax`, and `fmin`) by calling either an intrinsic or a C library function either of which expects `double` arguments. We previously converted the arguments to `_Common_float_type_t` which is `long double` when at least one argument is `long double`, resulting in narrowing conversion warnings at `/W4`. We now convert the arguments to `double` instead of `_Common_float_type_t`. Fixes microsoft#3246
barcharcraz
suggested changes
Dec 1, 2022
fsb4000
approved these changes
Dec 1, 2022
barcharcraz
approved these changes
Dec 2, 2022
StephanTLavavej
approved these changes
Dec 5, 2022
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - I checked <cmath> for other occurrences of casting arguments to common (case-insensitive) and found none.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for investigating and fixing this warning! 🔍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This template implements the "sufficient additional overloads" for two-argument
<cmath>functions (atan2,hypot,pow,fmod,remainder,copysign,nextafter,fdim,fmax, andfmin) by calling either an intrinsic or a C library function either of which expectsdoublearguments. We previously converted the arguments to_Common_float_type_twhich islong doublewhen at least one argument islong double, resulting in narrowing conversion warnings at/W4. We now convert the arguments todoubleinstead of_Common_float_type_t.Fixes #3246