Merged
Conversation
…ompat in stl/src. They're marked as _CRTIMP2_PURE in stl/src, so they'll continue to be exported.
Also, avoid calling a function before it's been declared (unintentional ADL and an unnecessary function call).
Co-authored-by: Casey Carter <Casey@Carter.net>
Fixes:
```
CMake Warning:
Manually-specified variables were not used by the project:
LIT_FLAGS
STL_USE_ANALYZE
```
strega-nil-ms
approved these changes
Oct 25, 2022
CaseyCarter
approved these changes
Oct 25, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
For posterity: I validated there are no other occurrences of LLVM-46269 in the STL after applying this change.
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
Author
|
I've pushed an additional commit to restore C4702 silencing for the internal chpe build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These non-overlapping changes are structured as a series of fine-grained commits for easy reviewing but are collected into a single PR to reduce the load on the CI system.
<xlocinfo>,<xlocnum>: The_Stofand_Stofxfamilies are unused, so we can remove their declarations fromstl/inc.xstof.cpp,xstod.cpp,xstold.cpp: We can comment their definitions as preserved for bincompat instl/src.xwstof.cpp,xwstod.cpp,xwstold.cpp: Also comment the wide definitions, which didn't have declarations._CRTIMP2_PURE, so they'll continue to be exported.<xlocinfo>:_GetLocaleForCPwas declared but never defined, so we can drop this extremely complicated declaration.<string>: Qualify_STD getline()._STD move(_Istr)fixes this, and makes all of these overloads call the actual implementation above.special_math.cpp: Now that we've merged updateboost-mathand fixstd::ellint_2#3077 to always use the standaloneboost-mathsubmodule, we can simplify this:BOOST_CHRONO_HEADER_ONLYandBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE.bessel.hppandgamma.hppemit MSVC/analyzewarning C6326: Potential comparison of a constant with another constant. boostorg/math#853. We also need to suppress C4702 for the MSVC-internal build's chpe architecture.P0896R4_ranges_alg_is_permutation/test.cpp: Nitpick, we conventionally avoid defining a struct and a variable simultaneously. DefineNonCopyableBoolandbseparately.payload_destructor, also removing an unnecessary semicolon.azure-devops/cmake-configure-build.yml: Followup to Update google-benchmark to 1.7.0 #3151, drop unused variables when configuring the benchmarks. This fixes a warning message printed by Azure Pipelines: