Skip to content

Properly constrain _Movable_box's copy constructors#3171

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
CaseyCarter:mbox
Oct 26, 2022
Merged

Properly constrain _Movable_box's copy constructors#3171
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
CaseyCarter:mbox

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Oct 21, 2022

We failed to add constraints when implementing the copyable-box to movable-box relaxation.

Drive-by: Rename _Not_same_as to _Different_from for consistency with the name change in the working draft.

@CaseyCarter
Properly constrain _Movable_box's copy constructors
ccd026a 
We failed to add constraints when implementing the _`copyable-box`_ to _`movable-box`_ relaxation.

Drive-by: Rename `_Not_same_as` to `_Different_from` for consistency with the name change in the working draft.
@CaseyCarter CaseyCarter added bug Something isn't working ranges C++20/23 ranges labels Oct 21, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner October 21, 2022 23:50
@CaseyCarter CaseyCarter mentioned this pull request Oct 21, 2022
Merged
@JMazurkiewicz
Copy link
Contributor

JMazurkiewicz commented Oct 25, 2022 •
edited
Loading

Note: code introduced by #3043 still uses _Not_same_as name instead of _Different_from.

StephanTLavavej and others added 2 commits October 25, 2022 16:16
@StephanTLavavej
Merge branch 'main' into mbox
437790d
@StephanTLavavej @JMazurkiewicz
Fix stealth build break.
1b0c304 
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 25, 2022

@JMazurkiewicz Thank you for noticing the stealth build break! 😻 😻 😻

@StephanTLavavej StephanTLavavej self-assigned this Oct 25, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 25, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 705265e into microsoft:main Oct 26, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 26, 2022

Thanks for fixing this bug that had such surprisingly complicated consequences, and for aligning the exposition-only concept's naming with the Working Draft! 📦 📦 📦

@CaseyCarter CaseyCarter deleted the mbox branch October 26, 2022 18:03
@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Oct 26, 2022

Thanks for fixing this bug that had such surprisingly complicated consequences, and for aligning the exposition-only concept's naming with the Working Draft! 📦 📦 📦

Dare I mention that the concept's name is no longer... different-from the working draft? 😎

@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Oct 26, 2022

(I'm so tempted to changelog this insignificant internal change as "Upon noticing that _Not_same_as was not the same as the name of the exposition-only concept in the working draft, renamed to _Different_from so it would no longer be different-from the working draft's name.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyCarter @JMazurkiewicz @StephanTLavavej @strega-nil-ms