Implement P2438R2 string::substr() &௱
Merged
StephanTLavavej merged 30 commits intomicrosoft:mainfrom Sep 1, 2022
Merged
Conversation
and update references to Working Draft
Contributor
Author
|
It seems that EDG is buggy here:
I'll skip relative cases for EDG. |
And conventionally use arrow comments.
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks, this looks great! I'll validate and push changes for the minor issues and nitpicks I found.
StephanTLavavej
approved these changes
Aug 31, 2022
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Aug 31, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Going to approve because I don't want to reset testing, but I'll address these comments in a followup.
Member
|
I've resolved a trivial adjacent-add conflict in |
Member
|
Thanks for implementing this feature in one of the STL's most-used data structures! 😻 ✅ 🧶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make the old and new
substruse default constructed allocators.(And consistently refer to WG21-N4910 in
<xstring>.)Fixes #2928.
Fixes #3022.
As implementation details, the rvalue substring constructors reuse the source storage if and only if
I have no idea how to portably test the probably intended behavior of newly added overloads...