`<__msvc_int128.hpp>`: Backport 128-bit integer-class types to C++14 mode by frederick-vs-ja · Pull Request #3036 · microsoft/STL

frederick-vs-ja · 2022-08-16T06:43:45Z

Thanks to @MattStephanson for having done the most works in #3012. As mentioned in #3012, having 128-bit integer-like types in all modes is useful for random number generation.

This PR also provides a library solution for DevCom-879048 with literal suffixes (__i128 and __u128) support.

Co-authored-by: Matt Stephanson <stephanson.matt@gmail.com>

And rerun.

frederick-vs-ja · 2022-08-16T10:39:54Z

Sometimes some (possibly unrelated) tests run forever. Is this triggering some compiler bug?

strega-nil-ms

saw some stuff, but I need to go pass out again (think I'm getting sick)

stl/inc/__msvc_int128.hpp

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

strega-nil-ms

Other than that, looks really good! thanks!

stl/inc/__msvc_int128.hpp

tests/std/tests/P1522R1_difference_type/test.cpp

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

strega-nil-ms · 2022-08-25T17:48:01Z

stl/inc/__msvc_int128.hpp

tests/std/tests/P1522R1_difference_type/test.cpp

StephanTLavavej · 2022-08-30T03:05:03Z

Thanks, this looks good! I pushed various minor changes:

Consistent preprocessor comments.
Always use braces for control flow.
Already constrained for is_integral_v.
Don't need to qualify numeric_limits.
Rename to _Int128_detail.
Add newline between non-chained if-statements.
Unnecessary parentheses.
_NODISCARD UDLs.
_NODISCARD helper functions.
Test capital 0B.
Test capital hexits.

StephanTLavavej · 2022-08-31T01:38:28Z

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej · 2022-08-31T04:22:33Z

I had to push two more commits to fix internal test failures:

EDG found two missed occurrences of _ZERO_OR_NO_INIT (I'm not sure why this was only found internally, but yay)
/clr:pure, the betrayer of hope, has notorious trouble with variable templates. I've converted the logic into struct specializations dispatching to a static member function.

StephanTLavavej · 2022-08-31T09:42:28Z

I had to push two more commits to fix internal test failures for /clr and /clr:pure on x64.

/clr:pure lacks virtually all intrinsics, so as usual we must avoid using them. Additionally, to avoid headaches, I am also disabling intrinsics for CUDA and the Intel compiler.
There is a silent bad codegen bug for plain /clr when asking the result of -6 multiplied by -2. I've added a workaround but haven't reduced/reported it.

StephanTLavavej · 2022-08-31T23:24:24Z

Thanks for bringing this Future Technology to the past! 🤖 ⌚ 🛰️

frederick-vs-ja and others added 2 commits August 16, 2022 14:27

Backport integer-class types to C++14 mode

70c9924

Co-authored-by: Matt Stephanson <stephanson.matt@gmail.com>

Test _Signed128/_Unsigned128 in all modes

918aa3b

frederick-vs-ja requested a review from a team as a code owner August 16, 2022 06:43

frederick-vs-ja added 4 commits August 16, 2022 14:49

Fix a misformatted line

67dfc72

Fixes needed for EDG

bf62790

Cleanup #if !defined(__EDG__)

a7f5e33

And rerun.

Test digit separators for UDLs instead of built-in ones

fc8cbce

And rerun.

strega-nil-ms reviewed Aug 16, 2022

View reviewed changes

stl/inc/__msvc_int128.hpp Outdated Show resolved Hide resolved

stl/inc/__msvc_int128.hpp Outdated Show resolved Hide resolved

StephanTLavavej added the enhancement Something can be improved label Aug 16, 2022

Address strega-nil-ms's review comments

c89d2e5

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

strega-nil-ms self-assigned this Aug 17, 2022

strega-nil-ms mentioned this pull request Aug 23, 2022

<random>: Implement Lemire's fast integer generation #3012

Merged

strega-nil-ms suggested changes Aug 24, 2022

View reviewed changes

stl/inc/__msvc_int128.hpp Outdated Show resolved Hide resolved

stl/inc/__msvc_int128.hpp Outdated Show resolved Hide resolved

tests/std/tests/P1522R1_difference_type/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P1522R1_difference_type/test.cpp Outdated Show resolved Hide resolved

strega-nil-ms assigned frederick-vs-ja and unassigned strega-nil-ms Aug 24, 2022

frederick-vs-ja and others added 3 commits August 25, 2022 12:26

Address strega-nil-ms's review comments, again

9dd1bba

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

Break line for clang-format

5bd7059

Use alternative order type for pre-C++20 and __cpp_lib_concepts

2115e43

strega-nil-ms approved these changes Aug 25, 2022

View reviewed changes

StephanTLavavej unassigned frederick-vs-ja Aug 26, 2022

StephanTLavavej added 8 commits August 29, 2022 18:04

Merge branch 'main' into int128-cxx14

8d9912e

Consistent preprocessor comments.

c5bfa9b

Always use braces for control flow.

71596b7

Already constrained for is_integral_v.

6111252

Don't need to qualify numeric_limits.

492607d

Rename to _Int128_detail.

a08e07a

Add newline between non-chained if-statements.

1a4026b

Unnecessary parentheses.

3b69a3e

StephanTLavavej added 4 commits August 29, 2022 19:21

_NODISCARD UDLs.

53d13a9

_NODISCARD helper functions.

65309f6

Test capital 0B.

eab9cdf

Test capital hexits.

bd95142

StephanTLavavej reviewed Aug 30, 2022

View reviewed changes

StephanTLavavej approved these changes Aug 30, 2022

View reviewed changes

StephanTLavavej self-assigned this Aug 31, 2022

StephanTLavavej added 2 commits August 30, 2022 20:12

Add two more occurrences of _ZERO_OR_NO_INIT.

dc2a92e

Avoid variable templates for /clr:pure.

badc4a3

StephanTLavavej approved these changes Aug 31, 2022

View reviewed changes

StephanTLavavej added 2 commits August 31, 2022 02:33

Avoid intrinsics for /clr:pure, CUDA, and Intel.

0632cd9

Work around /clr silent bad codegen.

3bb65df

StephanTLavavej approved these changes Aug 31, 2022

View reviewed changes

CaseyCarter approved these changes Aug 31, 2022

View reviewed changes

StephanTLavavej merged commit f441292 into microsoft:main Aug 31, 2022

frederick-vs-ja deleted the int128-cxx14 branch September 1, 2022 12:23

StephanTLavavej mentioned this pull request Nov 7, 2022

Enable /clr C++20 support #3194

Merged

fsb4000 mentioned this pull request Mar 13, 2023

more operator of int128 #3559

Closed

Conversation

frederick-vs-ja commented Aug 16, 2022

Uh oh!

frederick-vs-ja commented Aug 16, 2022

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

strega-nil-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil-ms commented Aug 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Aug 30, 2022

Uh oh!

StephanTLavavej commented Aug 31, 2022

Uh oh!

StephanTLavavej commented Aug 31, 2022

Uh oh!

StephanTLavavej commented Aug 31, 2022

Uh oh!

StephanTLavavej commented Aug 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants