<string_view>: suppress warning about annotation 'NullTerminated'#3032
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Aug 18, 2022
Merged
<string_view>: suppress warning about annotation 'NullTerminated'#3032StephanTLavavej merged 3 commits intomicrosoft:mainfrom
<string_view>: suppress warning about annotation 'NullTerminated'#3032StephanTLavavej merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Perhaps we can use |
CaseyCarter
reviewed
Aug 14, 2022
Co-authored-by: Casey Carter <Casey@Carter.net>
<string_view>: suppress warning about annotation 'NullTerminated'
CaseyCarter
approved these changes
Aug 16, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Just a few extraneous std::-qualifications, I'll apply changes.
StephanTLavavej
approved these changes
Aug 16, 2022
strega-nil-ms
approved these changes
Aug 17, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for nulling out this warning! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warning C6510: Invalid annotation: 'NullTerminated' property may only be used on buffers whose elements are of integral or pointer type: Function
'{ctor}' _Param_(1).https://gcc.godbolt.org/z/bPqs167he
Can we do something else and don't remove the annotation but fix the warning?
Found in one of LLVM tests.