Skip to content

<yvals_core.h> Update _MSVC_STL_UPDATE to #define _MSVC_STL_UPDATE 202208L#3020

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
lantastic99:main
Aug 12, 2022
Merged

<yvals_core.h> Update _MSVC_STL_UPDATE to #define _MSVC_STL_UPDATE 202208L#3020
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
lantastic99:main

Conversation

@lantastic99
Copy link
Contributor

@lantastic99 lantastic99 commented Aug 10, 2022 •
edited by strega-nil-ms
Loading

Fixes #2979

@lantastic99 lantastic99 requested a review from a team as a code owner August 10, 2022 09:22
@lantastic99 lantastic99 changed the title Update _MSVC_STL_UPDATE Update _MSVC_STL_UPDATE to #define _MSVC_STL_UPDATE 202208L Aug 10, 2022
@lantastic99 lantastic99 changed the title Update _MSVC_STL_UPDATE to #define _MSVC_STL_UPDATE 202208L <yvals_core.h> Update _MSVC_STL_UPDATE to #define _MSVC_STL_UPDATE 202208L Aug 10, 2022
@JMazurkiewicz
Copy link
Contributor

JMazurkiewicz commented Aug 10, 2022

PR description has wrong issue number (should be #2979).

strega-nil-ms
strega-nil-ms approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! This looks great
pom pom girl!

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Aug 10, 2022
@StephanTLavavej StephanTLavavej self-assigned this Aug 11, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Aug 11, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit db3eb43 into microsoft:main Aug 12, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Aug 12, 2022

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+5 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@frederick-vs-ja frederick-vs-ja frederick-vs-ja approved these changes

@JMazurkiewicz JMazurkiewicz JMazurkiewicz approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to August 2022

7 participants

@lantastic99 @JMazurkiewicz @StephanTLavavej @CaseyCarter @fsb4000 @frederick-vs-ja @strega-nil-ms