Merged
Conversation
We don't need all of <stdexcept>, and we don't need <random> commented-out. We need <cstdlib> for rand_s() and <xutility> for _Xout_of_range().
CaseyCarter
approved these changes
Aug 10, 2022
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<forward_list>,<list>,<vector>: Drop redundant access control.<variant>:_Convertible_from_allcan be an alias template.src/xrngdev.cpp: Drop totally redundant declaration of_Random_device().src/xrngdev.cpp: Include less machinery.<stdexcept>, and we don't need<random>commented-out.<cstdlib>forrand_s()and<xutility>for_Xout_of_range().P0220R1_polymorphic_memory_resources/test.cpp: Use https URL.tools/validate/CMakeLists.txt: Use C++23.src/xdateord.cpp: Repeat_CRTIMP2_PUREfrom the declaration in<xlocinfo>.src/xtime.cpp: Add_CRTIMP2_PUREand__cdeclto match declarations in<xtimec.h>.src/filesystem.cpp: Comment "copying from 2 consecutive DWORDs".<yvals.h>: Guard_Init_lockswith_CRTBLD, nothing instl/incneeds it.