STL: Remove !_HAS_EXACT_COMPOUND_REQUIREMENT fallback#301
STL: Remove !_HAS_EXACT_COMPOUND_REQUIREMENT fallback#301StephanTLavavej merged 1 commit intomicrosoft:masterfrom cpplearner:master
Conversation
|
|
CaseyCarter
left a comment
There was a problem hiding this comment.
This all looks correct - congratulations on submitting the first all-red PR! I'm happy to merge this contingent on tests passing. (Which they should unless there's a typo in here that I missed: we currently test concepts only with MSVC and it uses the _HAS_EXACT_COMPOUND_REQUIREMENT paths.)
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good to me. I verified that there are no occurrences of this macro remaining in the product code, and I also searched our (MSVC-internal but not for much longer) test code and found no occurrences.
|
I'm porting this to our Microsoft-internal MSVC repo now, for a full build and test run. |
|
This passed our tests, so I've merged it for the VS 2019 16.5 Preview 2 release. Thanks again for the cleanup, and congratulations on your first commit in the STL repo! |
Description
Fixes #299.
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.