P2321R2 zip: Make tuple, pair, and vector<bool>::reference indirectly_writable#2687
Conversation
c3509f7 to
7869d61
Compare
tuple, pair, and vector<bool>::reference indirectly_writable
7869d61 to
6a4351b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
strega-nil-ms
left a comment
There was a problem hiding this comment.
Alright, I'm about halfway through the review; I'll comment and submit now and continue later.
- tuple
- type_traits
- vector
strega-nil-ms
left a comment
There was a problem hiding this comment.
The rest looks reasonable to me; the only concern I have is using enable_if when requires would work.
|
Because EDG doesn't fully support concepts yet, we use The eventual cleanup of this is tracked by #602. |
strega-nil-ms
left a comment
There was a problem hiding this comment.
Given that we can't use requires here, this looks good to me; on a side note, it feels very weird to spend like 4 hours reviewing something and still not have any comments.
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks good to me; I had Billy look over my shoulder at it as well.
The only concern I had was adding a call to GetFileInformationByHandleEx, but was told it was inexpensive (and I noticed we're doing two calls anyways to get both basic and standard info), so I'm no longer concerned.
|
@strega-nil-ms I think your last comment was meant for #2373? |
|
Thanks, this is great! 😻 I saw no issues with the extensive template machinery, so I went ahead and pushed changes for the minor issues and nitpicks I noticed (the concepts guard and the |
|
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this foundational machinery for |
This implements the uninteresting parts of P2321R2, namely changes to
tuple,pairandvector<bool>::referenceto make them usable as proxy references.Partially addresses #2252.