Skip to content

Implement LWG-3648: format should not print bool with 'c'#2587

Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom
fsb4000:fix2555
Mar 2, 2022
Merged

Implement LWG-3648: format should not print bool with 'c'#2587
StephanTLavavej merged 5 commits intomicrosoft:mainfrom
fsb4000:fix2555

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Feb 21, 2022

Fixes #2555

@fsb4000 fsb4000 requested a review from a team as a code owner February 21, 2022 08:19
@cpplearner
Copy link
Contributor

cpplearner commented Feb 21, 2022

test_sane_c_specifier should be renamed as there's no "sane" c specifier now. Oh, it also tests the c specifier for char type, which makes it half-sane.

Maybe keep the format(STR("{:^c}"), true) and format(STR("{:c}"), true) tests, but change to use throw_helper?

@CaseyCarter CaseyCarter added format C++20/23 format LWG Library Working Group issue labels Feb 21, 2022
@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
@CaseyCarter CaseyCarter removed their assignment Feb 24, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 1, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit dafa1dd into microsoft:main Mar 2, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution that prevents this wacky combination! 🤪 😺 🎉

@fsb4000 fsb4000 deleted the fix2555 branch March 2, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

format C++20/23 format LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3648 format should not print bool with 'c'

5 participants