LWG-3610: iota_view::size sometimes rejects integer-class types#2542
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Feb 12, 2022
Merged
LWG-3610: iota_view::size sometimes rejects integer-class types#2542StephanTLavavej merged 5 commits intomicrosoft:mainfrom
iota_view::size sometimes rejects integer-class types#2542StephanTLavavej merged 5 commits intomicrosoft:mainfrom
Conversation
20 tasks
CaseyCarter
suggested changes
Feb 8, 2022
tests/std/tests/LWG3610_iota_view_size_and_integer_class/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Feb 9, 2022
tests/std/tests/LWG3610_iota_view_size_and_integer_class/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Feb 10, 2022
Member
|
Thanks! I pushed a one-line fix. FYI @CaseyCarter. |
CaseyCarter
approved these changes
Feb 10, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this LWG issue resolution fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposed resolution of LWG-3610.
Only tests the cases where an integer-class type is used as the bound type, because MSVC STL currently has no integer-class type satisfying
weakly_incrementable.