I notice there's issue with the tests and I will be looking into it very soon.

Here are the links to the relevant code lines for this issue:

It would be super awesome if you could also tackle #2402 while you are in the vicinity.

The relevant lines are

and

Note that we use _Pat for the type of the pattern so this should be && _Simple_view<_Pat>

It is totally fine if you do not want to tackle both

Thank you very much! I'm on it (I'll be taking on what you asked me to), sorry for my lack of experience and thank you very much for being so helpful!

Thank you very much! I'm on it (I'll be taking on what you asked me to), sorry for my lack of experience and thank you very much for being so helpful!

No worries, you can only get experience by trying it out and the stl is a complicated code base. If you need any help just ask right away

A peculiarity, using the following from the official LLVM GitHub releases page:

C:\Users\gabriel\Documents\GitHub\STL>clang-format --version
clang-format version 13.0.0

Here's what clang-format says:

C:\Users\gabriel\Documents\GitHub\STL>clang-format --dry-run -Werror stl/inc/ranges
stl/inc/ranges:2464:30: error: code should be clang-formatted [-Wclang-format-violations]
            return (_STD min) (_Length, static_cast<decltype(_Length)>(_Count));
                             ^
stl/inc/ranges:2469:30: error: code should be clang-formatted [-Wclang-format-violations]
            return (_STD min) (_Length, static_cast<decltype(_Length)>(_Count));
                             ^
stl/inc/ranges:2537:51: error: code should be clang-formatted [-Wclang-format-violations]
                    _Count            = (_STD min) (_RANGES distance(_Range), _Count);
                                                  ^
stl/inc/ranges:2795:48: error: code should be clang-formatted [-Wclang-format-violations]
                const auto _Offset = (_STD min) (_RANGES distance(_Range), _Count);
                                               ^
stl/inc/ranges:2816:44: error: code should be clang-formatted [-Wclang-format-violations]
            const auto _Offset = (_STD min) (_RANGES distance(_Range), _Count);
                                           ^
stl/inc/ranges:2907:40: error: code should be clang-formatted [-Wclang-format-violations]
                    _Count = (_STD min) (_RANGES distance(_Range), _Count);
                                       ^

Am I missing something? If so, sorry.

Thanks alot, formatting is still a pain point.

It also looks like the formatter is not too happy with some of the code but I am not sure whether it warrants turning it off.

I am slightly terrified that all Tests pass. I am going to bed now, but I hope to make some suggestions where to add Tests tomorrow if @CaseyCarter doesnt beat me to it

@cristeigabriel , @StephanTLavavej: I pushed a change to extract the boolean expression template argument out into a constexpr bool variable to make it clearer to clang-format that _Outer_iter < /* stuff */ > is a type and not an expression.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Thanks for implementing these LWG issue resolutions and congratulations on your first microsoft/STL commit! 🎉 😻 ✅

This will ship in VS 2022 17.2 Preview 2.