Skip to content

Implement LWG-3590: split_view::base() const & is overconstrained#2404

Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom
fsb4000:fix2400
Dec 17, 2021
Merged

Implement LWG-3590: split_view::base() const & is overconstrained#2404
StephanTLavavej merged 5 commits intomicrosoft:mainfrom
fsb4000:fix2400

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 11, 2021

Fixes #2400

@fsb4000 fsb4000 requested a review from a team as a code owner December 11, 2021 17:14
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks

Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
@fsb4000 fsb4000 changed the title Implement LWG-3590 Implement LWG-3590: split_view::base() const & is overconstrained Dec 12, 2021
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Dec 12, 2021
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a fix for my comments.

@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1174e73 into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution! 🚀 🎉 😺

@fsb4000 fsb4000 deleted the fix2400 branch December 17, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3590 split_view::base() const & is overconstrained

4 participants