P2372R3: Fix handling of locale in chrono formatters#2273
Merged
StephanTLavavej merged 6 commits intomicrosoft:mainfrom Nov 13, 2021
Merged
P2372R3: Fix handling of locale in chrono formatters#2273StephanTLavavej merged 6 commits intomicrosoft:mainfrom
StephanTLavavej merged 6 commits intomicrosoft:mainfrom
Conversation
CaseyCarter
suggested changes
Oct 20, 2021
Add the 'L' specifier to chrono formatter Add a test for localized chrono formatting Use dash in locale name for compatibility with old systems ABI mitigation, drop std:: and auto Keep ostream insertion operators localized
CaseyCarter
suggested changes
Nov 2, 2021
CaseyCarter
approved these changes
Nov 2, 2021
StephanTLavavej
requested changes
Nov 3, 2021
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! Product code looks great; I have a couple of requests for expanded test coverage.
tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 4, 2021
CaseyCarter
approved these changes
Nov 4, 2021
Member
|
@barcharcraz @CaseyCarter I forgot that we need to mention this paper in |
StephanTLavavej
approved these changes
Nov 4, 2021
CaseyCarter
approved these changes
Nov 4, 2021
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks @barcharcraz and @vitaut for implementing this C++20 DR! ✔️ ⌚ 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1892
In addition to that pull requests content (which is mirrored here, although squashed into one commit) I have
<chrono>Estimate width of aligned chronat strings #2017 )fixes: #2237
approved by plenary a week ago:
cplusplus/papers#1039