Skip to content

Update _MSVC_STL_UPDATE to October 2021#2233

Merged
CaseyCarter merged 1 commit intomicrosoft:mainfrom
Ukilele:main
Oct 9, 2021
Merged

Update _MSVC_STL_UPDATE to October 2021#2233
CaseyCarter merged 1 commit intomicrosoft:mainfrom
Ukilele:main

Conversation

@Ukilele
Copy link
Contributor

@Ukilele Ukilele commented Oct 3, 2021 •
edited
Loading

Fixes #2228

@Ukilele Ukilele requested a review from a team as a code owner October 3, 2021 11:23
fsb4000
fsb4000 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution 🎉

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 4, 2021
@StephanTLavavej StephanTLavavej changed the title Fixes #2228 Update _MSVC_STL_UPDATE to October 2021 Oct 4, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 4, 2021

Thanks! I've updated the PR title to mention _MSVC_STL_UPDATE, so we can see at a glance what your PR is doing. (Your PR description has properly linked it to the issue - mentioning issue numbers in titles doesn't have that linking effect.)

@Ukilele
Copy link
Contributor Author

Ukilele commented Oct 5, 2021

Thanks for your feedback everyone. It's helpful that you offer these good first issue. Hopefully I will be able to contribute more in the future.

@CaseyCarter CaseyCarter self-assigned this Oct 8, 2021
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Oct 8, 2021

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter merged commit 8833270 into microsoft:main Oct 9, 2021
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Oct 9, 2021

Congratulations on your first STL contribution!! 🎉🎉 😹

@CaseyCarter CaseyCarter removed their assignment Oct 9, 2021
@Ukilele
Copy link
Contributor Author

Ukilele commented Oct 9, 2021

Thank you 😺 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to October 2021

4 participants

@Ukilele @StephanTLavavej @CaseyCarter @fsb4000