Skip to content

<tuple>: LWG-3528 make_from_tuple can perform (the equivalent of) a C-style cast#2160

Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
frederick-vs-ja:patch-1
Sep 2, 2021
Merged

<tuple>: LWG-3528 make_from_tuple can perform (the equivalent of) a C-style cast#2160
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
frederick-vs-ja:patch-1

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 26, 2021

Although requires is used in LWG-3528, I believe that only hard error is required, because std::make_from_tuple itself is still unconstrained.

Works towards #1965.

Use static_assert as std::make_from_tuple is unconstrained.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner August 26, 2021 03:12
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Aug 26, 2021
@StephanTLavavej StephanTLavavej self-assigned this Sep 2, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 205aed7 into microsoft:main Sep 2, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution and guarding against the evils of C-style casts! 🧛 🧟 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants