Don't call bit_width if value is nullptr in _Fmt_write#2097
Don't call bit_width if value is nullptr in _Fmt_write#2097StephanTLavavej merged 11 commits intomicrosoft:mainfrom
Conversation
|
Done! |
|
Also this is technically a performance patch since we do the check anyway, but now moving it first before we call the function in the event value is nullptr |
|
@miscco done! |
barcharcraz
left a comment
There was a problem hiding this comment.
This looks correct, but I'm not 100% convinced it's a performance improvement except in debug mode. But debug perf is important too, so I'm fine with it.
|
Issues addressed! |
|
So when can we merge, if I may ask? |
They usually merge multiple PRs at the same time, so it may take a while. |
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. (As @sam20908 mentioned, the mirroring process is semi-manual, and requires enough effort that we batch up PRs in order to save dev time. Your PR will be part of the next batch of 17 PRs. There's no set schedule for mirroring, although it tends to be completed at the end of each week.) |
|
Thanks for improving this codepath! 🚀 🎉 😸 |
No description provided.