<type_traits>: std::byte is _Is_trivially_swappable_v#2044
Merged
StephanTLavavej merged 7 commits intomicrosoft:mainfrom Jul 30, 2021
Merged
<type_traits>: std::byte is _Is_trivially_swappable_v#2044StephanTLavavej merged 7 commits intomicrosoft:mainfrom
<type_traits>: std::byte is _Is_trivially_swappable_v#2044StephanTLavavej merged 7 commits intomicrosoft:mainfrom
Conversation
miscco
approved these changes
Jul 7, 2021
AdamBucior
reviewed
Jul 11, 2021
Contributor
AdamBucior
left a comment
There was a problem hiding this comment.
I think we should also add the specializations for types like duration and time_point (if their underlying type is trivially swappable)
Contributor
Author
How does such specialization look like? I'm sorry I do not understand. |
Contributor
|
CaseyCarter
suggested changes
Jul 12, 2021
tests/std/tests/GH_002039_byte_is_not_trivially_swappable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
Jul 14, 2021
StephanTLavavej
approved these changes
Jul 27, 2021
Member
|
Thanks for extending this optimization! 🚀 🚀 🐈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2039