<chrono> LWG-3536: leave duration unchanged on failed parse#2037
<chrono> LWG-3536: leave duration unchanged on failed parse#2037StephanTLavavej merged 5 commits intomicrosoft:mainfrom
<chrono> LWG-3536: leave duration unchanged on failed parse#2037Conversation
|
|
mnatsuhara
left a comment
There was a problem hiding this comment.
Thanks for working on this issue! Apologies for the delay in review, the maintainers have been steadily working through the PR backlog. The actual product code changes look great, the only changes I'm requesting are some additional test cases! Once you add those, I'll be satisfied 😸
mnatsuhara
left a comment
There was a problem hiding this comment.
Thanks for pushing changes addressing my review comments! These changes look good to me -- moving into "Final Review" mode now 😸
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks for implementing this LWG issue resolution! This looks good to me - I'll push changes for minor clarity improvements.
|
FYI @mnatsuhara, I pushed minor changes after you approved. |
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
|
Thanks for implementing this LWG issue resolution, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This will ship in VS 2022 17.1 Preview 1. |
Fixes #1740.