<chrono>: Fix hh_mm_ss subsecond formatting for floats#1866
Merged
eldakesh-ms merged 2 commits intomicrosoft:chronat2from Apr 20, 2021
Merged
<chrono>: Fix hh_mm_ss subsecond formatting for floats#1866eldakesh-ms merged 2 commits intomicrosoft:chronat2from
eldakesh-ms merged 2 commits intomicrosoft:chronat2from
Conversation
Before, the same formatting string was used for floats and integrals. This meant that large floats were formatted using exponent notaion and small floats were not, and it also meant there was an extra period in a time, as the subseconds could be fractions of a subsecond (say .4 nanoseconds). Now if the subseconds are floats, we force fixed formatting to get the right number of leading zeroes and a precision of 0 to round off fractions of subseconds.
Contributor
Author
|
Per discord discussion with @statementreply: Currently this rounds, but after some deliberation truncation probably makes more sense. The spec is a bit ambiguous on this. If we do rounding, we need to pull the subsecond into the seconds (if it rounds up to a whole second), and this can mean that a second becomes a minute and a minute becomes an hour. I think truncation is the easiest solution, but maybe I a missing something. |
StephanTLavavej
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the same formatting string was used for floats and integrals.
This meant that large floats were formatted using exponent notaion and
small floats were not, and it also meant there was an extra period in a
time, as the subseconds could be fractions of a subsecond (say .4
nanoseconds). Now if the subseconds are floats, we force fixed
formatting to get the right number of leading zeroes and a precision of
0 to round off fractions of subseconds.