Fix error in take_view::begin by casting to the appropriate size#1844
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom May 1, 2021
Merged
Fix error in take_view::begin by casting to the appropriate size#1844StephanTLavavej merged 2 commits intomicrosoft:mainfrom
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
Note: we could use _Convert_size here but that would add additional overhead for questionable gain
CaseyCarter
approved these changes
Apr 20, 2021
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Has someone submitted an LWG issue yet to fix the wording?
Contributor
LWG telecon today approved P2367R0. |
StephanTLavavej
approved these changes
Apr 28, 2021
Member
|
Thanks for fixing this bug and improving the ranges experience! 😺 🪲 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: we could use _Convert_size here but that would add additional overhead for questionable gain
This addresses https://developercommunity2.visualstudio.com/t/1397309
Thanks to @statementreply for pointing it out