Azure Pipelines: Move VMSS location, don't publish artifacts#1654
Merged
CaseyCarter merged 2 commits intomicrosoft:mainfrom Feb 17, 2021
Merged
Azure Pipelines: Move VMSS location, don't publish artifacts#1654CaseyCarter merged 2 commits intomicrosoft:mainfrom
CaseyCarter merged 2 commits intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CaseyCarter
approved these changes
Feb 17, 2021
MahmoudGSaleh
approved these changes
Feb 17, 2021
Contributor
|
I'm going to merge this now and port to the feature branches, rather than waiting for @StephanTLavavej to do so as we usually would, to unblock us. I will delay merging to MSVC for the next batch to avoid wasting CI cycles for what is effectively a non-functional change as far as the internal repo is concerned. |
This was referenced Feb 17, 2021
Contributor
|
Note that I did not Changelog this PR. We typically changelog the VMSS updates because they include changes to our required tool versions, but this PR has no such changes. I don't think it's of great interest to our contributors where the CI runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Azure Pipelines checks were unable to run for most of Tuesday (2021-02-16), briefly from (Pacific Time) 3:39 PM to 3:49 PM and then continuously from 5:09 PM until now (~2 AM Wednesday), with the error message:
It doesn't appear that we're over budget, and vcpkg was experiencing the same error. Attempting to create VMs of many different SKUs in West US 2 failed, so it's not specific to our current SKU. Attempting to create VMs in West US and South Central US also failed. However, @BillyONeal had the idea to try a different continent (suspecting that recent extreme weather in the US was related), and the first region I tried, North Europe, succeeded.
If this Virtual Machine Scale Set can scale up to handle a build/test run, I think we should switch to it temporarily. We don't perform very much network access (just cloning repos, and we have gone to considerable lengths to minimize how much of llvm-project we download), and it isn't latency-sensitive at all.
And on the topic of network access, I recently noticed that we're uploading and storing a zillion bytes. This PR attempts to fix #1653 in a minimal way, leaving the machinery in place if it needs to be refined in the future.