Skip to content

P1614R2 Spaceship: Clause 27: Time (partial, pre-C++20 types)#1602

Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom
statementreply:spaceship-clause-27
Feb 19, 2021
Merged

P1614R2 Spaceship: Clause 27: Time (partial, pre-C++20 types)#1602
StephanTLavavej merged 4 commits intomicrosoft:mainfrom
statementreply:spaceship-clause-27

Conversation

@statementreply
Copy link
Contributor

@statementreply statementreply commented Jan 30, 2021 •
edited
Loading

This PR patches pre-C++20 <chrono> types.

#323 has already implemented WG21-P1614 for the new calendar types.

@statementreply statementreply requested a review from a team as a code owner January 30, 2021 16:59
@statementreply statementreply marked this pull request as draft January 30, 2021 17:02
@statementreply statementreply marked this pull request as ready for review January 30, 2021 17:32
@StephanTLavavej StephanTLavavej added cxx20 C++20 feature spaceship C++20 operator <=> labels Jan 31, 2021
@MattStephanson
Copy link
Contributor

MattStephanson commented Feb 1, 2021

I had implemented these for utc_clock et al. I don't mind waiting, just FYI that this is blocking other work.

@statementreply
Copy link
Contributor Author

statementreply commented Feb 2, 2021

I had implemented these for utc_clock et al. I don't mind waiting, just FYI that this is blocking other work.

Would it be better if I retarget this PR to main branch to unblock <chrono> work?

@MattStephanson
Copy link
Contributor

MattStephanson commented Feb 2, 2021 •
edited
Loading

Oh, I forgot there's a feature branch for these. I'm using operator<=>(leap_second,sys_time) (thus, operator<=>(time_point,time_point)) for std::get_leap_second_info, so it would be useful for me to have it. But I could also rewrite it and move the leap-related <=> to feature/spaceship as well.

@StephanTLavavej StephanTLavavej self-assigned this Feb 3, 2021
@statementreply statementreply changed the base branch from feature/spaceship to main February 4, 2021 13:50
@statementreply
Copy link
Contributor Author

statementreply commented Feb 4, 2021

Force-pushed, retarget to main.

StephanTLavavej
StephanTLavavej reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll push a test.lst update.

@StephanTLavavej StephanTLavavej removed their assignment Feb 18, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 18, 2021

I've mirrored this to internal MSVC-PR-305171.

Please note: Further changes are still possible (e.g. if you notice something, or if final review leads to more feedback that should be addressed before merging), but they must be replicated to the mirror PR in order to avoid codebase divergence.

@StephanTLavavej StephanTLavavej changed the title feature/spaceship: Clause 27: Time (partial, pre-C++20 types) P1614R2 Spaceship: Clause 27: Time (partial, pre-C++20 types) Feb 19, 2021
@StephanTLavavej StephanTLavavej merged commit 1043b11 into microsoft:main Feb 19, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 19, 2021

Thanks for implementing these timeships and unblocking further work on C++20 timezones! ⏲️ 🛸 😺

@StephanTLavavej StephanTLavavej mentioned this pull request Feb 20, 2021
Merged
@statementreply statementreply deleted the spaceship-clause-27 branch April 17, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@MahmoudGSaleh MahmoudGSaleh MahmoudGSaleh approved these changes

Assignees

No one assigned

Labels

cxx20 C++20 feature spaceship C++20 operator <=>

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@statementreply @MattStephanson @StephanTLavavej @MahmoudGSaleh