<type_traits>: Implement Layout-compatibility and Pointer-interconvertibility Traits#1575

Merged

StephanTLavavej merged 9 commits intomicrosoft:mainfrom

MahmoudGSaleh:master

Jan 31, 2021

Member

MahmoudGSaleh commented Jan 19, 2021 •

edited by StephanTLavavej

Loading

This PR implements P0466R5. It will close #18.

This is ready for review:

implement feature calling by compiler intrinsics in <type_traits>
implement tests
All tests passing (including clang and BE)

The following bugs are used to track related issues:

LLVM-48860 - MSVC Compatibility: Implement intrinsics for P0466R5 - Layout-compatibility and Pointer-interconvertibility Traits
VSO-1268984 - [EDG] New compiler intrinsics for Layout-compatibility and Pointer-interconvertibility Traits need to be understood by EDG


          Draft implementation of P0466R5 Layout-Compatibility And Pointer-Inte…

c8120cd

…rconvertibility Traits

MahmoudGSaleh requested a review from a team as a code owner

January 19, 2021 21:54

StephanTLavavej added the cxx20 label

StephanTLavavej marked this pull request as draft

January 19, 2021 23:07

StephanTLavavej changed the title ~~<type_traits>: WIP - implement Layout-compatibility and Pointer-interconvertibility Traits~~ <type_traits>: Implement Layout-compatibility and Pointer-interconvertibility Traits

Member

StephanTLavavej commented Jan 19, 2021

I've marked this PR as a draft and removed WIP from the title.

Many of the test failures are caused by Clang not understanding the new compiler builtins. We should request them by filing an LLVM bug, and then guard the definitions accordingly.

StephanTLavavej requested changes

View reviewed changes

stl/inc/type_traits Outdated Show resolved Hide resolved

stl/inc/type_traits Outdated Show resolved Hide resolved

stl/inc/type_traits Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

CaseyCarter suggested changes

View reviewed changes

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

stl/inc/type_traits Outdated Show resolved Hide resolved

stl/inc/type_traits Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

MahmoudGSaleh added 2 commits

January 21, 2021 22:46


          Updates to PR based on feedback

33c80cd

* Fix functions declarations
* Add feature test macros tests
* Update tests


          Test fixes for consistency

54ce30d

MahmoudGSaleh commented

View reviewed changes

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved


          Fix clang-format issues

cfbb97f

Member Author

MahmoudGSaleh commented Jan 22, 2021

Analyzing the x86 failures.

cpplearner reviewed

View reviewed changes

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

CaseyCarter reviewed

View reviewed changes

stl/inc/type_traits Show resolved Hide resolved


          Fix BE test failures and cv-qualifiers tests

6a8e3e9

MahmoudGSaleh marked this pull request as ready for review

January 22, 2021 20:39

MahmoudGSaleh requested review from CaseyCarter and StephanTLavavej

January 22, 2021 20:41

CaseyCarter suggested changes

View reviewed changes

tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp Show resolved Hide resolved

stl/inc/type_traits Outdated Show resolved Hide resolved


          Fix ordering of tests in feature_test_macros

84083f1

CaseyCarter approved these changes

View reviewed changes

StephanTLavavej requested changes

View reviewed changes

stl/inc/type_traits Outdated Show resolved Hide resolved

stl/inc/yvals_core.h Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved


          Apply PR code review feedback

f49d233

- Updated LLVM bug # for adding intrinsics to clang
- Added condition for using outdated vs renamed intrinsics
- Added new tests per review feedback

MahmoudGSaleh requested a review from StephanTLavavej

January 26, 2021 23:58

CaseyCarter suggested changes

View reviewed changes

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved


          Apply fixes from feedback comments

c115942

MahmoudGSaleh requested a review from CaseyCarter

January 27, 2021 18:52

CaseyCarter approved these changes

View reviewed changes

CaseyCarter assigned StephanTLavavej

Base automatically changed from master to main

January 28, 2021 00:35

CaseyCarter mentioned this pull request

Update LLVM submodule reference #1594

Merged

StephanTLavavej reviewed

View reviewed changes

Member

StephanTLavavej left a comment

This looks great! I'll verify and push a change to use static_cast for nullptr, then I'll mirror this to MSVC.

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Show resolved Hide resolved

tests/std/tests/P0466R5_layout_compatibility_and_pointer_interconvertibility_traits/test.cpp Outdated Show resolved Hide resolved


          static_cast nullptr to use template argument deduction.

53a91b1

StephanTLavavej approved these changes

View reviewed changes

CaseyCarter approved these changes

View reviewed changes

StephanTLavavej merged commit c319a7b into microsoft:main

Member

StephanTLavavej commented Jan 31, 2021

Thanks for implementing this feature with a comprehensive set of tests, and congratulations on your first microsoft/STL commit! 🎉 😸

MahmoudGSaleh mentioned this pull request

<type_traits>: Remove _IS_LAYOUT_COMPATIBLE_SUPPORTED macro and related __builtin*() intrinsics #1637

Closed

MahmoudGSaleh mentioned this pull request

MSVC Compatibility: Implement intrinsics for P0466R5 - Layout-compatibility and Pointer-interconvertibility Traits llvm/llvm-project#48204

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx20