You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the CTAD upgrade! I pushed a couple of changes:
Rename the macro being used to stamp out the packaged_task deduction guides for different calling conventions, so it's not the same as the macro being used for function. This makes it easier to search the codebase, even though there was no actual conflict (because we immediately #undef the macros).
Add test coverage. Since we already had good test coverage for function, I simply templatized it. The only extra work necessary (aside from guarding this against /clr and /clr:pure) was that function is copyable while packaged_task is movable-only. I used if constexpr to test copy construction when available for function, and move construction always.
Thanks for making packaged_task easier to use! 📦 🐈 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LWG-3117 Missing
packaged_taskdeduction guidesI've got deduction guides from
function, because there are similar requirements forpackaged_taskdeduction guides. All tests are passedFixes #1465