Merged
Conversation
cbezault
approved these changes
Oct 8, 2020
CaseyCarter
approved these changes
Oct 8, 2020
Contributor
|
Thanks for all five of your contributions, and for displaying the level of tenacity the STL requires! |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followups to GH-1344 requested by @cbezault.
xutility&& !defined(_M_ARM64EC)to the end for clarity. There's no behavioral change here (_M_ARM64ECcan be defined only when_M_X64is defined), it just separates the major architectures where we want to enable the vectorized algorithms (x86, x64) from the flavors where they should be excluded due to intrinsic unavailability.stl/msbuild/stl_base/msvcp.settings.targetsstl/msbuild/stl_atomic_wait/stl_atomic_wait.files.settings.targetsvector_algorithms.cpp/clr:pure, so that can be a hard#error. However, we do need to make this file a no-op for_M_ARM64EC. Extract that, likexutilityabove.I tested this with MSVC-internal builds of x86, x64, arm, arm64, and chpe (there is no dedicated arm64ec build).
(Recreated yet again, hopefully Azure Pipelines will work now.)