XFG: made _Execute_once XFG-compatible.#1318
Merged
StephanTLavavej merged 1 commit intomicrosoft:masterfrom Sep 25, 2020
jrabet:xfg_xonce
Merged
XFG: made _Execute_once XFG-compatible.#1318StephanTLavavej merged 1 commit intomicrosoft:masterfrom jrabet:xfg_xonce
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
jrabet:xfg_xonce
Conversation
StephanTLavavej
approved these changes
Sep 25, 2020
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
I've verified that these changes are identical to the reviewed changes in internal MSVC-PR-276974; looks good to me.
CaseyCarter
approved these changes
Sep 25, 2020
Member
|
Thanks for making the STL compatible with this security feature! 🔒 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Execute_once_fp_t and PINIT_ONCE_FN differ in type signature, therefore we introduce _Xfg_trampoline which has PINIT_ONCE_FN's type signature and calls into _Callback as an _Execute_once_fp_t for XFG compatibility.