Fix 2 VS 16.8p3 blocked issues#1291
Merged
StephanTLavavej merged 3 commits intomicrosoft:masterfrom Sep 23, 2020
Merged
Conversation
Contributor
Author
|
Interesting, it only auto linked one of the issues, I guess it doesn't understand "and". 😕 I don't suppose there's a way to not run the tests when submitting a PR? Seems a bit of a wasted effort seeing as this depends on a yet to be merged update. |
CaseyCarter
approved these changes
Sep 15, 2020
cbezault
approved these changes
Sep 15, 2020
Member
That's correct - the Words Of Power must be repeated. See: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
StephanTLavavej
approved these changes
Sep 16, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks for following up on these issues - removing workarounds helps our compilers stay conformant! 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1152 and #1199