Remove noexcept from coroutine_handle<>::resume and operator()#1182
Merged
StephanTLavavej merged 1 commit intomicrosoft:masterfrom Aug 11, 2020
Merged
Remove noexcept from coroutine_handle<>::resume and operator()#1182StephanTLavavej merged 1 commit intomicrosoft:masterfrom
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
Conversation
With the adoption of [coroutine issue 25](http://open-std.org/JTC1/SC22/WG21/docs/papers/2018/p0664r6.html#25) it is no longer undefined behavior for an exception to escape the body of a coroutine, e.g. by rethrowing from `unhandled_exception`. Compiler support for handling such an exception was introduced to MSVC with version 16.7, and with this support it is now well-defined for `resume` to exit with an exception. This PR removes the strengthened noexcept specifiers from both `resume` and `operator()` which previously trapped the undefined behavior.
CaseyCarter
approved these changes
Aug 11, 2020
StephanTLavavej
approved these changes
Aug 11, 2020
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
I wonder whether we should have comments along the lines of "must not be strengthened", but perhaps the eventual addition of test coverage will cover this. In any event, this has already been merged in MSVC.
Member
|
Thanks for this exceptional improvement! 😎 |
Contributor
Thanks for this amazing co_ntribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the adoption of coroutine issue 25
it is no longer undefined behavior for an exception to escape the body
of a coroutine, e.g. by rethrowing from
unhandled_exception. Compilersupport for handling such an exception was introduced to MSVC with
version 16.7, and with this support it is now well-defined for
resumeto exit with an exception. This PR removes the strengthened noexcept
specifiers from both
resumeandoperator()which previously trappedthe undefined behavior.