-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
questionFurther information is requestedFurther information is requested
Description
This include:
Line 15 in 313964b
| #include <cwchar> |
Is used for wmemchr optimization, it was introcuded in 2024.
The <cwchar> brings in <intrin.h>, which we have always been avoided for throughput reasons. Probably it started bringing it in specifically for wmemchr optimization.
What should we do now? I see three opposite paths forward:
- Drop
#include <cwchar>and currentwmemchroptimizations. Almost no impact asvector_algorithms.cppis preferred most of the time anyway. - Get SDK fixed to use
<intrin0.h>. - Do nothing, accept throughput impact.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested