Call `__fastfail` instead of `abort()` in more places

# Where don't call `abort()`

Since `__fastfail` is considered a superior way to fail, and nobody asked for specific behavior in most of the places where we call abort, let's replace `abort()` calls in:

**1. Places that are not implementable in `!_HAS_EXCEPTIONS` mode:**

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/xlocale#L446-L450

**2. Places that seems like direct result of doing something wrong:**

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/functional#L1354-L1357

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/utility#L959-L964

**3. Places that handle broken invariant:**

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/atomic#L2992-L2994

**4. Places that handle robust WinAPI functions failures**

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/xcall_once.h#L97-L99

**5. Places that are inherently dead code paths and exist due to having to implement a virtual function:**

https://github.com/microsoft/STL/blob/cbd091e4170a84dfb8beca3119ab8e3188988848/stl/inc/functional#L891-L893

----

# What call instead

In headers we have the following alternatives:
 * `_STL_REPORT_ERROR`
 * `_MSVC_STL_DOOM_FUNCTION`

In separately compiled code we probably should directly call `__fastfail`.

	#if _HAS_EXCEPTIONS
	_Throw_bad_cast(); // lazy disallowed
	#else
	_CSTD abort(); // lazy disallowed
	#endif

	_EXPORT_STD [[noreturn]] __forceinline void unreachable() noexcept /* strengthened */ {
	_STL_UNREACHABLE;
	#ifdef _DEBUG
	_CSTD abort(); // likely to be called in debug mode, but can't be relied upon - already entered the UB territory
	#endif // defined(_DEBUG)
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call `__fastfail` instead of `abort()` in more places #5529

Where don't call `abort()`

What call instead

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	[[noreturn]] _Rx __stdcall _Function_not_callable(const _Move_only_function_data&, _Types&&...) noexcept {
	_CSTD abort(); // Unlike std::function, move_only_function doesn't throw bad_function_call
	// (N4950 [func.wrap.move.inv]/2)
	}

	if (!_RENAME_WINDOWS_API(__std_init_once_begin_initialize)(&_Once._Opaque, 0, &_Pending, nullptr)) {
	_CSTD abort();
	}

	[[noreturn]] const type_info& _Target_type() const noexcept override {
	_CSTD abort(); // shouldn't be called, see GH-3888
	}

	default: // Unrecognized bit pattern
	_CSTD abort();
	}

Call __fastfail instead of abort() in more places #5529

Description

Where don't call abort()

What call instead

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Call `__fastfail` instead of `abort()` in more places #5529

Where don't call `abort()`