-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
cxx26C++26 featureC++26 featurefixedSomething works now, yay!Something works now, yay!good first issueGood for newcomersGood for newcomers
Description
WG21-P2968R2 Make std::ignore A First-Class Object
No feature-test macro is mentioned.
We're already conforming to the improved specification (except for the location of std::ignore).
Lines 122 to 130 in 165fc94
| struct _Ignore { // struct that ignores assignments | |
| template <class _Ty> | |
| constexpr const _Ignore& operator=(const _Ty&) const noexcept /* strengthened */ { | |
| // do nothing | |
| return *this; | |
| } | |
| }; | |
| _EXPORT_STD _INLINE_VAR constexpr _Ignore ignore{}; |
So the only things need to be done are
- moving
_Ignoreandignoreto<utility>, - removing the
/* strengthened */comment from theoperator=, and - adding the
// P2968R2 Make std::ignore A First-Class Objectcomment to<yvals_core.h>immediately after this line
Line 81 in 165fc94
// P2937R0 Freestanding Library: Remove strtok
This issue is intended for a new contributor (especially one new to GitHub) to get started with the simplest possible change.
Please feel free to submit a pull request if there isn't one already linked here - no need to ask for permission! 😸
You can (and should) link your pull request to this issue using GitHub's close/fix/resolve syntax. (in the PR description not the commit message)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
cxx26C++26 featureC++26 featurefixedSomething works now, yay!Something works now, yay!good first issueGood for newcomersGood for newcomers
Type
Projects
Status
Done