Skip to content

<yvals_core.h>: Unify stringification macros #4314

New issue
New issue
Closed
#4405
Closed
<yvals_core.h>: Unify stringification macros#4314
#4405
Labels
enhancementSomething can be improvedfixedSomething works now, yay!
@frederick-vs-ja

Description

@frederick-vs-ja
frederick-vs-ja
opened on Jan 13, 2024

Currently, MSVC STL defines two stringization macros in <yvals_core.h> for mutually exclusive cases.

STL/stl/inc/yvals_core.h

Lines 25 to 26 in 3eac329

#define _STL_STRINGIZE_(S) #S
#define _STL_STRINGIZE(S) _STL_STRINGIZE_(S)

STL/stl/inc/yvals_core.h

Lines 1946 to 1947 in 3eac329

#define _STRINGIZEX(x) #x
#define _STRINGIZE(x) _STRINGIZEX(x)

Would it be better to unconditionally defined one and consistently use it?

Also, _EMIT_STL_MESSAGE currently relies on _CRT_STRINGIZE.

STL/stl/inc/yvals_core.h

Line 518 in 3eac329

#define _EMIT_STL_MESSAGE(MESSAGE) _STL_PRAGMA_MESSAGE(__FILE__ "(" _CRT_STRINGIZE(__LINE__) "): " MESSAGE)

Would it be better to change to use the STL-internal version?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSomething can be improvedfixedSomething works now, yay!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions