-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
bugSomething isn't workingSomething isn't workingfixedSomething works now, yay!Something works now, yay!
Description
basic_string::operator=(const&) is still problematic even after #3862. For example:
Lines 3170 to 3175 in 60f1885
| _Traits::copy(_Unfancy(_New_ptr), _Right_ptr, _Right_size + 1); | |
| _Tidy_deallocate(); | |
| _Mypair._Myval2._Bx._Ptr = _New_ptr; | |
| _Mypair._Myval2._Mysize = _Right_size; | |
| _Mypair._Myval2._Myres = _New_capacity; | |
| } else { |
- After
_Tidy_deallocatethe string is left in SSO mode, so the pointer should be constructed instead of assigned. - The new allocation lacks ASAN annotation.
These are what I can find. As the branch is in such a broken state, I'm uncertain whether there are other problems.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingfixedSomething works now, yay!Something works now, yay!