-
Notifications
You must be signed in to change notification settings - Fork 431
[DateTime] Update SpanishDateTime resource #2508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DateTime] Update SpanishDateTime resource #2508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the proper way to handle resource updates. The build process should automatically update such resource code files during the build process (via the YAML files).
Perhaps there is a silent failure somewhere in the resource generation process?
Downstream consumers of the recognizers should rely on the generated packages and not in code files in the repository, if that's the case here.
|
Hi @tellarin, these changes were added after executing the build.cmd of Java, they are not manually updated. The compilation of datetime is failing as the property To reproduce the issue using
|
|
@Batta32, I meant to say that if the build process generates such files correctly, than there can never be a compilation failure. |
|
@tellarin - doing the manual build (executing C# is working as PR #2503 introduced the changes in the DateTimeDefinitions, however Java/JavaScript/Python don't contain those last changes in the autogenerated resources. Just to know, which should be the correct way to update the autogenerated files in order to have the |
|
@Batta32, think we're talking past each other. |
|
Awesome @tellarin! Thanks for the explanation. I'll close this PR then 😊. |

Description
The SpanishDateTimeParserConfiguration doesn't recognize the SpanishDateTime.LastNightTimeRegex as the resource is not updated. The compilation fails without updating the resource.
Specific Changes
Update the SpanishDateTime resource with the latest changes.
Testing
Java build correctly passing
