Skip to content

Build docs with Sphinx 3.4.1#2560

Merged
github-actions[bot] merged 9 commits intomicrosoft:masterfrom
jenshnielsen:sphinx_340_support
Jan 5, 2021
Merged

Build docs with Sphinx 3.4.1#2560
github-actions[bot] merged 9 commits intomicrosoft:masterfrom
jenshnielsen:sphinx_340_support

Conversation

@jenshnielsen
Copy link
Copy Markdown
Collaborator

Sphinx now extract instance attribute docs from the super class so remove duplicated attributes

@jenshnielsen
Copy link
Copy Markdown
Collaborator Author

jenshnielsen commented Dec 25, 2020

Search is broken with the current latest version of the read the docs theme. readthedocs/sphinx_rtd_theme#1021

Need to wait for a new release of read the docs that includes that pr

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 25, 2020

Codecov Report

Merging #2560 (3acaa36) into master (08d5e8b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2560   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files         198      198           
  Lines       25929    25929           
=======================================
  Hits        16493    16493           
  Misses       9436     9436           

@jenshnielsen jenshnielsen added blocked on third party dependency dependencies Pull requests that update a dependency file labels Dec 27, 2020
@jenshnielsen jenshnielsen changed the title Build docs with Sphinx 3.4.1 Build docs with Sphinx 3.4.2 Jan 4, 2021
@jenshnielsen
Copy link
Copy Markdown
Collaborator Author

jenshnielsen commented Jan 5, 2021

Looks like 3.4.2 broke something that was working in 3.4.1 so once #2589 is merged we could revert this back to 3.4.1 or wait for a fix (in 3.4.3). It seems likely this issue will be fixed by sphinx-doc/sphinx#8653

Edit fixed incorrect link to sphinx pr

Update again. Will be fixed by sphinx-doc/sphinx#8656

@jenshnielsen jenshnielsen changed the title Build docs with Sphinx 3.4.2 Build docs with Sphinx 3.4.1 Jan 5, 2021
@github-actions github-actions bot merged commit c604631 into microsoft:master Jan 5, 2021
@jenshnielsen jenshnielsen deleted the sphinx_340_support branch January 5, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants