Always On Top: Dedup the alwaysontop command id in window system menu#45845
Merged
Always On Top: Dedup the alwaysontop command id in window system menu#45845
Conversation
zateutsch
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We picked a command id for always on top, although it has little possibility, but may collide with other window system menu item, so before inject, try to see if it persists, if yes, then we don't inject.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
A window with the same id
You can see there is no always ontop overriding the test item
Normal window:
