Settings UI: Fix spelling error and make spell checker happy#41403
Settings UI: Fix spelling error and make spell checker happy#41403vanzue merged 4 commits intomicrosoft:mainfrom
Conversation
Replaces _Navigatable_ to _navigable_ and removes lines from `expect.txt` that triggered forbidden pattern error with spellchecker.
|
Ping @vanzue Sorry to intrude, but the invalid entry in expect.txt is causing issues in every build since that PR was merged. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sorry, my bad, did not notice this, thanks for the correct ❤️ |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a spelling error in the PowerToys Settings UI codebase by renaming NavigatablePage to NavigablePage throughout multiple files. The change also reverts corresponding entries in the spell checker's exclude list to resolve forbidden pattern errors.
- Fixes spelling error in class name from
NavigatablePagetoNavigablePage - Updates all references across 40+ settings page files (both .cs and .xaml files)
- Removes spell checker exclusions that were causing pattern violations
Reviewed Changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/settings-ui/Settings.UI/Helpers/NavigablePage.cs | Renames the base class from NavigatablePage to NavigablePage |
| src/settings-ui/Settings.UI/SettingsXAML/Views/*.xaml.cs | Updates class inheritance declarations to use corrected NavigablePage |
| src/settings-ui/Settings.UI/SettingsXAML/Views/*.xaml | Updates XAML references to use corrected NavigablePage |
| .github/actions/spell-check/expect.txt | Removes excluded terms that caused spell checker violations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Seems that the additional merge triggers the spell checker again. Forbidden pattern again, but with a different cause.
|
|
Seems a false positive, let me fix that |
|
I can’t address it for a few hours—it’s already 4 AM here, and I really need some sleep. 😇😴 |
|
No worry, thank you so much for initiating, let me fix that |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Summary of the Pull Request
NavigatablePagetoNavigablePageto fix a spelling error.exclude.txtthat triggered a forbidden pattern error in the spell checker.NavigatablePageinexclude.txtbecause of its automatic casing rules.Regression: #41285